Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing old line preventing PyGRB workflows from starting #4840

Merged
merged 1 commit into from
Oct 26, 2024
Merged

Removing old line preventing PyGRB workflows from starting #4840

merged 1 commit into from
Oct 26, 2024

Conversation

sebastiangomezlopez
Copy link
Contributor

@sebastiangomezlopez sebastiangomezlopez commented Aug 3, 2024 •
edited by titodalcanton
Loading

We do not need this line of code anymore since --num-trials is now passed via config files

Standard information about the request

This is a: bug fix

This change affects: PyGRB

This change: has appropriate unit tests, follows style guidelines (See e.g. PEP8), has been proposed using the contribution guidelines

This change will: fix pycbc_make_offline_grb_workflow which is presently showing the following error:

Traceback (most recent call last):
  File "/home/sebastian.gomezlopez/.conda/envs/pygrb_prod/bin/pycbc_make_offline_grb_workflow", line 442, in <module>
    _workflow.setup_pygrb_pp_workflow(wflow, pp_dir, seg_dir,
  File "/home/sebastian.gomezlopez/.conda/envs/pygrb_prod/lib/python3.9/site-packages/pycbc/workflow/grb_utils.py", line 317, in setup_pygrb_pp_workflow
    node, trig_files = job_instance.create_node(wf.ifos, seg_dir, segment,
  File "/home/sebastian.gomezlopez/.conda/envs/pygrb_prod/lib/python3.9/site-packages/pycbc/workflow/grb_utils.py", line 375, in create_node
    node.add_opt("--num-trials", self.num_trials)
  File "/home/sebastian.gomezlopez/.conda/envs/pygrb_prod/lib/python3.9/site-packages/pycbc/workflow/pegasus_workflow.py", line 220, in add_opt
    raise ValueError(err_msg)
ValueError: Trying to set option --num-trials with value 6, but it has already been provided by the configuration file. Usually this should not be given in the config file, but contact developers to check

@sebastiangomezlopez sebastiangomezlopez added bug PyGRB PyGRB development labels Aug 3, 2024
@sebastiangomezlopez sebastiangomezlopez self-assigned this Aug 3, 2024
@titodalcanton
Copy link
Contributor

I am going to ask @pannarale to review this, since I was the one suggesting we might need this change, but was not entirely sure.

@pannarale
Copy link
Contributor

This is due to pycbc_make_offline_grb_workflow on master being out of date. I am opening at least 2 PRs to bring pycbc_make_offline_grb_workflow, grb_utils.py, and pycbc_pygrb_pp_workflow on master up to date with my local changes (which do run properly end-to-end)

@pannarale pannarale closed this Sep 11, 2024
@pannarale pannarale reopened this Oct 25, 2024
@sebastiangomezlopez sebastiangomezlopez merged commit b008b9c into gwastro:master Oct 26, 2024
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pannarale pannarale pannarale approved these changes

@titodalcanton titodalcanton Awaiting requested review from titodalcanton

Assignees

@sebastiangomezlopez sebastiangomezlopez

Labels
bug PyGRB PyGRB development
Projects
PyGRB Development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sebastiangomezlopez @titodalcanton @pannarale